Fix IntegrationTest.yml template to emit valid multi-line YAML#140
Merged
Conversation
The previous template emitted `pkgs: |<entries>` with content joined to the
literal-block scalar marker on the same line, producing invalid YAML when
package names were present. Fix by placing `{DOWNSTREAMPKGS}` on its own line
and updating `format_downstreampkgs` to emit a JSON-array form indented under
the block scalar:
pkgs: |
[
"Foo",
"Bar"
]
The empty case emits `pkgs: |\n []`. This matches the format already
used across ecosystem packages (e.g. SparseArraysBase) and is consumed by
ITensorActions/.github/workflows/IntegrationTest.yml@v2 via fromJSON.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 87.34% 87.42% +0.07%
==========================================
Files 1 1
Lines 158 159 +1
==========================================
+ Hits 138 139 +1
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfishman
added a commit
to ITensor/ITensorTestPackage.jl
that referenced
this pull request
May 8, 2026
## Summary - Regenerated `.github/workflows/` from the latest `ITensorPkgSkeleton` template. - Adds `CheckCompatBounds`, `CodeQL`, and `FormatCheckComment`; updates the rest to current ecosystem conventions (action versions, job names, permissions blocks). - `IntegrationTest.yml` uses the multi-line JSON-array `pkgs:` form consumed by `ITensorActions/IntegrationTest.yml@v2` (matching the fix in ITensor/ITensorPkgSkeleton.jl#140).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous
IntegrationTest.yml.templateplaced{DOWNSTREAMPKGS}on the same line as thepkgs: |block-scalar marker, andformat_downstreampkgsjoined entries without a leading newline or array wrapper. With downstream packages this produced invalid YAML; with no downstreams it produced a confusing empty literal block.This PR fixes both halves so generation emits the multi-line JSON-array form already used across ecosystem packages and consumed by
ITensorActions/.github/workflows/IntegrationTest.yml@v2viafromJSON(inputs.pkgs):pkgs: |\n [\n "Foo",\n "Bar"\n ]pkgs: |\n []Existing tests (which check for
pkgs: |and the package name) continue to pass; verified the generated YAML in both cases against a clean process.